[ejabberd] MUC bug

Peter Saint-Andre stpeter at jabber.org
Wed Apr 18 19:46:49 MSD 2007


On Wed, Apr 18, 2007 at 02:10:14PM +0200, Magnus Henoch wrote:
> Peter Saint-Andre <stpeter at jabber.org> writes:
> 
> > Yes, you're right, I thought about it more and the stanza that Psi
> > sends is essentially impossible to interpret. However, I do think that
> > the MUC implementation needs to return a <bad-format/> error here. :)
> 
> Or <bad-request/>, since <bad-format/> is a stream error.

Right, sorry about that.

> Here is a patch that returns <bad-request/>, <malformed-jid/> or
> <not-allowed/>, depending on what was actually wrong.  It is also an
> Erlang style experiment, in that it departs from the ejabberd custom
> of covering each possible error in the normal execution path (which
> requires deeply nested case statements) and instead throws exceptions
> upwards.

Great, thanks!

/psa



More information about the ejabberd mailing list