[ejabberd] [PATCH] mod_shared_roster: Teach remove_user_from_group() and add_user_to_group() about special users

Martin Langhoff martin.langhoff at gmail.com
Wed Apr 22 02:02:17 MSD 2009


On Tue, Apr 21, 2009 at 3:22 PM, Badlop <badlop at gmail.com> wrote:
> I've submitted a bug report:
> https://support.process-one.net/browse/EJAB-916
>
> Your path looks almost good. For ejabberd svn, I just removed those
> groups that are not implemented in ejabberd. For OLPC you will still
> need to apply a patch, but it will be smaller :)

Thanks for the kind feedback, and glad that you found the patch usable
and desirable. And that you merged it too! ;-)

> For your reference, I attach a diff between your original patch and my
> patch in 916.

Very useful, thanks.

> BTW, when reporting a bug/misfeature, it helps to provide an example
> usage, or the steps to reproduce the problem (if possible). See my
> report for an example.

Will do.  Thanks for the hint.

My patch also talked about '@online@', @recent@ and @nearby at . I have a
patch that implements @online@ and works well on 2.0.x, if I clean it
up, would it be interesting / desirable?

(The same patch has bits of @recent@ and @nearby@ but they don't work.
I'm thinking of removing the non-working cruft to focus on the well
tested @online@).

cheers!



martin
-- 
 martin.langhoff at gmail.com
 martin at laptop.org -- School Server Architect
 - ask interesting questions
 - don't get distracted with shiny stuff  - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff


More information about the ejabberd mailing list