[ejabberd] [PATCH] mod_shared_roster: Sanity check in remove_user_from_group() and add_user_to_group()

Martin Langhoff martin.langhoff at gmail.com
Wed Apr 22 02:03:46 MSD 2009


On Tue, Apr 21, 2009 at 12:46 PM, Badlop <badlop at gmail.com> wrote:
> This is what I understood:

Thanks for the very detailed analysis of the patch -- I had some
suspicion that it made sense to allow it in some cases, as per your
[3] and [4]... but being new to ejabberd internals...

> In your OLPC-ejabberd, this patch may be useful, as you know what
> exact usage mod_shared_roster will get from your admins. However, the
> generic ejabberd has a wide range of usages.

On OLPC, this will be mediated -- there's a series of scripts that
call ejabberdctl -- so I actually don't need the patch. So I'll drop
it from my version too to keep things simple.

thanks!


m
-- 
 martin.langhoff at gmail.com
 martin at laptop.org -- School Server Architect
 - ask interesting questions
 - don't get distracted with shiny stuff  - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff


More information about the ejabberd mailing list