[ejabberd] mod_time:process_local_iq/3 doesn't work for negative TZ values

Alexander Zhukov zuav at yandex.ru
Tue Nov 30 12:48:33 MSK 2010


>>>>> Badlop  (B) writes:

 B> 2010/11/26 Alexander Zhukov <zuav at yandex.ru>:
 >> I've checked the sources and found that jlib:timestamp_to_iso/2
 >> called only from mod_time:process_local_iq/3 and from
 >> jlib:timestamp_to_xml/4.

 B> As that function is exported, it may be used by other modules not
 B> included in ejabberd mainline. I've added your case clause, and kept
 B> the other clause anyway.

OK, I did not thought about other modules just grep'ed ejabberd sources.

 >> In the message I did included the patch againt ejabberd-2.1.5
 >> sources.  Please, feel free to apply it to ejabberd if you like it.

 B> Yes, I've applied it to ejabberd.

 B> BTW, there was a half-solution applied in 2.1.x:
 B> https://support.process-one.net/browse/EJAB-1301


 >> BTW, what is the Right way to send patches/fixes to ejabberd?

 B> I started writing this based in what I see; it isn't yet discussed,
 B> but it can serve in the meantime:
 B> https://support.process-one.net/doc/display/MESSENGER/Guidelines+for+ejabberd+developers

Thank you.

-- 
Alexander Zhukov


More information about the ejabberd mailing list